Skip to content

feat: add ochami rcs XXX subcommands#96

Merged
synackd merged 2 commits into
OpenCHAMI:mainfrom
cjh1:rcs
Jul 22, 2026
Merged

feat: add ochami rcs XXX subcommands#96
synackd merged 2 commits into
OpenCHAMI:mainfrom
cjh1:rcs

Conversation

@cjh1

@cjh1 cjh1 commented Jun 3, 2026

Copy link
Copy Markdown
Member

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Description

This adds subcommands to access the remote console service:

ochami rcs service status - Return the status of the service.
ochami rcs console list - List the currently active consoles.
ochami rcs console show <xname> - Show the console output for a particular console.
ochami rcs console connect <xname> - Will connect you to an interactive console session.

The best way to try this out is to use the dev docker-compose env in remote-console, which will setup an environment with a mock console. This can be brought up using:

docker compose -f docker-compose-devel.yaml up

You can then update you config with the folllowing:

        rcs:
            uri: http://localhost:26776/remote-console

Then you should be able run for example:

ochami rcs console connect x0c0s1b0

Fixes #72

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

For more info, see Contributing Guidelines.

@cjh1
cjh1 marked this pull request as draft June 3, 2026 19:56
@cjh1
cjh1 force-pushed the rcs branch 4 times, most recently from 3f6206f to 81316a7 Compare June 3, 2026 20:25
@cjh1
cjh1 marked this pull request as ready for review June 3, 2026 20:30
@cjh1

cjh1 commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

@synackd Do you know what is up with the CI here?

@synackd

synackd commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Looks like something with Chainguard. I reran the job and it completed fine.

Thanks for this change @cjh1! Got some fixes I'm trying to get in as well as metadata-service stuff for the new release PR, but I will take a look at this when I can.

@synackd
synackd self-requested a review June 11, 2026 21:41
@cjh1

cjh1 commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

Looks like something with Chainguard. I reran the job and it completed fine.

Thanks, I figured it was probably something transient, but didn't have the power to rerun the job.

Thanks for this change @cjh1! Got some fixes I'm trying to get in as well as metadata-service stuff for the new release PR, but I will take a look at this when I can.

No rush, thanks

@synackd synackd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested just yet, but am requesting some small code/docs changes in the meantime. Also, there have been some features that have been merged in that have modified go.mod. Can you rebase, resolve the conflicts, and go mod tidy?

Comment thread man/ochami-rcs.1.sc Outdated
Comment thread man/ochami-rcs.1.sc Outdated
Comment thread pkg/client/rcs/rcs.go
Comment thread pkg/client/rcs/rcs.go
Comment thread internal/cli/rcs/rcs.go
Comment thread cmd/root.go
Comment thread cmd/rcs/console/console.go Outdated
@cjh1
cjh1 force-pushed the rcs branch 4 times, most recently from a8a5d3a to fc63ab0 Compare June 23, 2026 18:43

@synackd synackd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this using the development docker-compose file and it appears to work fine. Just have a couple small comments to resolve and we can merge this.

Comment thread man/ochami-rcs.1.sc Outdated
Signed-off-by: Chris Harris <cjh@lbl.gov>
@cjh1

cjh1 commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

@synackd I think this is now ready to go?

@synackd
synackd merged commit 7d2428a into OpenCHAMI:main Jul 22, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add 'ochami console' command

2 participants